ref(sveltekit): Extract propagation context #8428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Jun 30, 2023
There was a problem hiding this comment.
q: Do we need to adjust things in the client-side SvelteKit fetch instrumentation?
I understand that this PR handles incoming requests/handlers but I'm wondering if we need to adjust from where we take the DSC/tracing data for outgoing requests.
EDIT: Nevermind, this is adressed in the PR description of #8434, i just missed this initially.
Lms24
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8352
Use the
tracingContextFromHeadershelper (first used in #8422) to simplify how trace context is generated by the Sveltekit SDK . Then set the propagation context accordingly.